Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plan9port: #77228

Closed
wants to merge 1 commit into from
Closed

nixos/plan9port: #77228

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jan 7, 2020

Add NixOS option to make Plan 9 from User Space globally available via the
PLAN9 environmental variable.

Motivation for this change

I've used Plan9port with NixOS for as long as I can remember, and I believe this is the best method of integration (Acme is a great editor for Nix expressions). Obviously this is a trivial NixOS module, but I think that it is useful documentation and better than a note on the wiki.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AndersonTorres @bbarker @ftrvxmtrx @KoviRobi - plan9port maintainers

@ehmry
nixos/plan9port:
2a43b27 
Add NixOS option to make Plan 9 from User Space globally available via the
PLAN9 environmental variable.
@ehmry ehmry requested a review from infinisil as a code owner January 7, 2020 13:20
@KoviRobi
Copy link
Contributor

KoviRobi commented Jan 7, 2020

Probably a silly question, I haven't used anything from plan9port for ages, but why not just wrap the binaries with this environment variable?

@ehmry
Copy link
Contributor Author

ehmry commented Jan 7, 2020

Probably a silly question, I haven't used anything from plan9port for ages, but why not just wrap the binaries with this environment variable?

Actually, digging deeper I see that the 9 command does this wrapping. So this module is not necessary if one can remember to run 9 acme or 9 rc.

@ehmry ehmry closed this Jan 7, 2020
@KoviRobi
Copy link
Contributor

KoviRobi commented Jan 7, 2020

That rings a bell, I think it's because some of the plan9port programs conflict with the GNU programs (in names, with incompatible flags), so this is how we 'namespace' it. Should document it though!

@bbarker
Copy link
Contributor

bbarker commented Jan 7, 2020

Should document it though!

Agreed, I had totally forgotten about that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehmry @KoviRobi @bbarker