Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 71.0 -> 72.0 (and other firefox packages as well) #77331

Merged
merged 7 commits into from Jan 8, 2020
Merged

firefox: 71.0 -> 72.0 (and other firefox packages as well) #77331

merged 7 commits into from Jan 8, 2020

Conversation

andir
Copy link
Member

@andir andir commented Jan 8, 2020

Motivation for this change

This bumps firefox and related package to the lastest version. The NSS update is required by Firefox 72 and accounts for ~8k rebuilds. This might be fine to just hit master instead of going through staging..

Things done
  • Tested using NixOS VM test
  • made @fpletz test it :)

@andir andir requested a review from fpletz January 8, 2020 18:50
@ofborg ofborg bot requested a review from edolstra January 8, 2020 18:59
fpletz
fpletz approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention that I had to cherry-pick the actual firefox bump from the 19.09 backport PR. Pushed. 😄

@fpletz
Copy link
Member

fpletz commented Jan 8, 2020 •
edited

Since the 19.09 PR #77292 was merged, we should merge this now too. I agree that we should target master. 👍

@fpletz fpletz merged commit d01cc96 into NixOS:master Jan 8, 2020
@fpletz fpletz mentioned this pull request Jan 8, 2020
Closed
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 8, 2020
@fpletz @dtzWill
Merge pull request NixOS#77331 from andir/firefox72
5090d06 
firefox: 71.0 -> 72.0 (and other firefox packages as well)
(cherry picked from commit d01cc96)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 8, 2020
@dtzWill
Revert "Merge pull request NixOS#77331 from andir/firefox72" (rebuild…
b9730ee 
…s, nss)

This reverts commit 5090d06.
@lheckemann
Copy link
Member

2020-01-09-140056_screenshot
Not sure if it was this or 72.0.1, but the fonts in various parts of the UI look a bit funky now.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 21, 2020
@dtzWill
Revert "Revert "Merge pull request NixOS#77331 from andir/firefox72" …
cf6f2d0 
…(rebuilds, nss)"

This reverts commit b9730ee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @fpletz @lheckemann