Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/httpd: symlink apache configuration to /etc/httpd/httpd.conf for use in the apachectl command #77326

Merged
merged 1 commit into from
Jan 16, 2020
Merged

nixos/httpd: symlink apache configuration to /etc/httpd/httpd.conf for use in the apachectl command #77326

merged 1 commit into from
Jan 16, 2020
+4 −0

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 8, 2020

Motivation for this change
~> apachectl configtest
AH00543: httpd: bad user name daemon

The apachectl configtest command is using the example configuration provided by the apacheHttpd package, instead of the system generated configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@aanderse aanderse requested a review from Mic92 January 8, 2020 15:43
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 8, 2020
@ofborg ofborg bot requested review from lovek323 and peti January 8, 2020 15:52
peti
peti approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not particularly happy about the introduction of an impure global path, but I am not sure what would be a better way to accomplish the goal, i.e. allowing users to run apachectl configtest. If anyone has a better idea, I'd love to hear it. In the absence of suggestions, I suppose we could go this route.

@aanderse
Copy link
Member Author

@peti I understand. The only reason I file this PR is because I now have a need for this and I haven't been able to come up with a better solution ☹️ Thanks for looking.

@aanderse
Copy link
Member Author

ping @zimbatm who has been helpful when mulling over httpd related issues. Any better ideas?

@aanderse aanderse merged commit 7260d2e into NixOS:master Jan 16, 2020
@aanderse aanderse deleted the apacheHttpd branch January 16, 2020 02:02
@zimbatm
Copy link
Member

zimbatm commented Jan 16, 2020

sorry about the wait. I don't see a better solution so post-merge 👍

@aanderse
Copy link
Member Author

aanderse commented Feb 2, 2020 •
edited
Loading

@peti @zimbatm this finally occurred to me as an alternative: https://github.com/NixOS/nixpkgs/compare/master...aanderse:apachectl?expand=1

Worth a PR to cleanup /etc?

@zimbatm
Copy link
Member

zimbatm commented Feb 2, 2020

if you believe it's the right thing to do I would say go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

@Mic92 Mic92

@lovek323 lovek323

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @zimbatm @peti