Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status-page: add alerts for github issues #93

Merged
merged 2 commits into from Jan 8, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 7, 2020

status-page

/cc @grahamc

@samueldr
Copy link
Member

samueldr commented Jan 7, 2020

The age labels are not of a specific width, which causes the alert text to be off.

image

Using display-block we can set a min-width. Using these it should be correct for most sizes. A 2em margin was kept in case it is larger than 6em.

Additionally, a 10px top margin for the div#alerts is required for the appropriate bootstrap 2 metrics. Otherwise it's too close to the navbar.

diff --git a/delft/eris/status-page/status.css b/delft/eris/status-page/status.css
index 8b3b821..7b6be18 100644
--- a/delft/eris/status-page/status.css
+++ b/delft/eris/status-page/status.css
@@ -12,8 +12,16 @@
   max-width: 15em;
 }
 
+.issue-age {
+	min-width: 6em;
+	display: inline-block;
+}
 .issue-link {
-    margin-left: 3em;
+    margin-left: 2em;
+}
+
+#alerts {
+	margin-top: 10px;
 }
 
 .github {

@samueldr
Copy link
Member

samueldr commented Jan 8, 2020

👍 for the concept, execution is on par with the existing code. Could need a cleanup, but I think it should be handled as a whole rather than on a per-improvement basis.

@zimbatm zimbatm merged commit 3294705 into NixOS:master Jan 8, 2020
@LnL7 LnL7 deleted the status-page-alerts branch January 8, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants