Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.coordinates: init at 0.4.0 #77335

Merged
merged 2 commits into from Jan 9, 2020
Merged

python3Packages.coordinates: init at 0.4.0 #77335

merged 2 commits into from Jan 9, 2020

Conversation

mildlyincompetent
Copy link
Contributor

Motivation for this change

Packaging coordinates, a python module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mildlyincompetent
Copy link
Contributor Author

@GrahamcOfBorg build python36Packages.coordinates python37Packages.coordinates python38Packages.coordinates

bcdarwin
bcdarwin suggested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See a couple comments, mainly disabling for unsupported Pythons. Python 3 version build on my NixOS machine.

pkgs/development/python-modules/coordinates/default.nix Show resolved Hide resolved
pkgs/development/python-modules/coordinates/default.nix Outdated
};

# No tests in PyPi source distribution.
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've requested these be bundled with the PyPi dist, but possibly consider switching to the GitHub release for now?

@bcdarwin
Copy link
Member

bcdarwin commented Jan 8, 2020 •
edited

Also, please update the PR/commit message to a buildable package name, here python3Packages.coordinates: .... Thanks!

jonringer
jonringer reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the commit message should be:

pythonPackages.coordinates: init at 0.4.0

pkgs/development/python-modules/coordinates/default.nix Show resolved Hide resolved
@mildlyincompetent mildlyincompetent changed the title coordinates: init at 0.4.0 python3Packages.coordinates: init at 0.4.0 Jan 9, 2020
@mildlyincompetent
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.coordinates python36Packages.coordinates python37Packages.coordinates python38Packages.coordinates

@mildlyincompetent
Copy link
Contributor Author

mildlyincompetent commented Jan 9, 2020 •
edited

Thanks for the advice everyone, I've

  • Switched to the github release, as that includes tests
  • Disabled for python 3.5 and below
  • Fixed the commit message

Let me know if there's anything further.

jonringer
jonringer approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77335
2 package were built:
python37Packages.coordinates python38Packages.coordinates

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.coordinates python38Packages.coordinates

@jonringer jonringer merged commit d84fb64 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mildlyincompetent @bcdarwin @jonringer