ocaml-sqlite3: 2.0.9 -> 5.0.1 #77295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
Jan 8, 2020
vbgl
requested changes
Jan 9, 2020
| @@ -1,18 +1,16 @@ | |||
| { stdenv, fetchurl, sqlite, ocaml, findlib, ocamlbuild, pkgconfig }: | |||
| { stdenv, fetchurl, sqlite, ocaml, pkgconfig, dune-configurator, buildDune2Package }: | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchurl, sqlite, ocaml, pkgconfig, dune-configurator, buildDune2Package }: | |
| { lib, fetchurl, sqlite, pkgconfig, buildDunePackage }: |
| stdenv.mkDerivation rec { | ||
| pname = "ocaml-sqlite3"; | ||
| version = "2.0.9"; | ||
| buildDune2Package rec { |
There was a problem hiding this comment.
Suggested change
| buildDune2Package rec { | |
| buildDunePackage rec { |
| buildInputs = [ ocaml findlib ocamlbuild sqlite ]; | ||
|
|
||
| createFindlibDestdir = true; | ||
| buildInputs = [ dune-configurator ocaml sqlite ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ dune-configurator ocaml sqlite ]; | |
| buildInputs = [ sqlite ]; |
| buildInputs = [ ocaml findlib ocamlbuild sqlite ]; | ||
|
|
||
| createFindlibDestdir = true; | ||
| buildInputs = [ dune-configurator ocaml sqlite ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
My testing methodology has been insufficient to catch the build failure. I've been running |
|
I've made the suggested improvements |
vbgl
reviewed
Jan 10, 2020
Co-Authored-By: Vincent Laporte <vbgl@users.noreply.github.com>
vbgl
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
version bump
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Massegi @vbgl