Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: 0.12.18 -> 0.12.19 #77350

Merged
merged 1 commit into from Jan 9, 2020
Merged

terraform: 0.12.18 -> 0.12.19 #77350

merged 1 commit into from Jan 9, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 9, 2020

Motivation for this change

Changelog: https://github.com/hashicorp/terraform/releases/tag/v0.12.19

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

babariviere
babariviere approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my system 🙂

@marsam marsam merged commit bda5f79 into NixOS:master Jan 9, 2020
@marsam marsam deleted the update-terraform branch January 9, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babariviere babariviere babariviere approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@zimbatm zimbatm Awaiting requested review from zimbatm

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @babariviere