Skip to content

pacman: fix script generation #77334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

pacman: fix script generation #77334

merged 1 commit into from
Jan 9, 2020
+2 −2

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Without m4, the bash scripts (makepkg, repo-add, etc.) would be installed as empty files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mt-caret

Sorry, something went wrong.

@lopsided98
pacman: fix script generation
7066dc9 
Without m4, the bash scripts (makepkg, repo-add, etc.) would be installed as
empty files.
@ofborg ofborg bot requested a review from mt-caret January 8, 2020 19:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 8, 2020
worldofpeace
worldofpeace approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at makepkg before this change and the file was empty, and now it isn't 👍
Works.

@worldofpeace worldofpeace merged commit 2206d51 into NixOS:master Jan 9, 2020
@lopsided98 lopsided98 deleted the pacman-m4-dep branch January 13, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@mt-caret mt-caret

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @worldofpeace