Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-fhs-userenv: runCommand -> runCommandLocal #77253

Merged
merged 1 commit into from Feb 14, 2020
Merged

build-fhs-userenv: runCommand -> runCommandLocal #77253

merged 1 commit into from Feb 14, 2020

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Jan 7, 2020

Motivation for this change

It's a trivial derivation, no need to build remotely (it's slower that
way).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bjornfor
build-fhs-userenv: runCommand -> runCommandLocal
44b4a1e 
It's a trivial derivation, no need to build remotely (it's slower that
way).
@doronbehar
Copy link
Contributor

So what's the purpose of this change? What's supposed to be with all of the derivations that use this function?

@bjornfor
Copy link
Contributor Author

bjornfor commented Jan 8, 2020

I don't know about other derivations, but from my quick testing, this is faster to build locally than remotely, even when the remote machine is on gigabit network and is more powerful than the local machine.

@danbst danbst merged commit d394c82 into NixOS:master Feb 14, 2020
@dtzWill
Copy link
Member

dtzWill commented Feb 14, 2020

👍 thanks!

@bjornfor bjornfor deleted the build-fhs-user-env-locally branch February 14, 2020 18:49
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 14, 2020
@bjornfor @dtzWill
build-fhs-userenv: runCommand -> runCommandLocal (NixOS#77253)
b356ba2 
It's a trivial derivation, no need to build remotely (it's slower that
way).

(cherry picked from commit d394c82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjornfor @doronbehar @dtzWill @danbst