Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] hobbes: init at 2020-03-10 #84002

Merged
merged 3 commits into from Apr 2, 2020
Merged

[20.03] hobbes: init at 2020-03-10 #84002

merged 3 commits into from Apr 2, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 1, 2020

Backports #79699 so that the new package is available in 20.03.

CC @thmzlt

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thomaz Leite added 3 commits April 1, 2020 12:34
@bhipple
maintainers: add thmzlt
b18e7d7 
(cherry picked from commit 063795f)
@bhipple
hobbes: init at unstable-2020-03-10
538929b 
(cherry picked from commit 704e604)
@bhipple
hobbes: mark as broken on Darwin
609bf4b 
(cherry picked from commit 2ac8f8f)
@bhipple
Copy link
Contributor Author

bhipple commented Apr 1, 2020

@GrahamcOfBorg eval

@thmzlt
Copy link
Contributor

thmzlt commented Apr 1, 2020

Hey, how can I help? I'm not familiar with the backport process.

@bhipple
Copy link
Contributor Author

bhipple commented Apr 1, 2020

If you checkout my branch, build it, and verify that hobbes runs as you'd expect, that's sufficient (post a PR comment stating results, one way or the other).

I've verified that it at least builds; trying to figure out why OfBorg is unhappy evaluating the set, but I expect it's an issue related to the release-20.03 branch itself, not this PR.

@thmzlt
Copy link
Contributor

thmzlt commented Apr 2, 2020

If you checkout my branch, build it, and verify that hobbes runs as you'd expect, that's sufficient (post a PR comment stating results, one way or the other).

Built hobbes from your branch and ran a few expressions on hi (its interactive console). Looks good.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from thmzlt April 2, 2020 01:22
@bhipple bhipple merged commit c922cde into NixOS:release-20.03 Apr 2, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Apr 2, 2020

Issue was indeed unrelated to this PR, for the record; since the build is now green I merged it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmzlt thmzlt Awaiting requested review from thmzlt

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @thmzlt @jonringer