catcli: init at 0.5.13 #84078
catcli: init at 0.5.13 #84078
Conversation
petersjt014
changed the title
|
Had to undo/redo the commit to split adding the package and myself as a maintainer into separate commits. |
| homepage = "https://github.com/deadc0de6/catcli"; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ petersjt014 ]; | ||
| platforms = with platforms; [ x86_64-linux i686-linux ]; |
There was a problem hiding this comment.
it builds on my pi...
| platforms = with platforms; [ x86_64-linux i686-linux ]; | |
| platforms = platforms.all; |
There was a problem hiding this comment.
Just tried and it builds natively on mine too.
Unfortuantely, the raspberryPi cross-build target still doesn't work (and I haven't tested it on macos, any of the bsds or anything else) so I'm hesitant to use all for now.
If there's a platform option that just covers x64/i686/aarch64 I would feel comfortable switching to that one though. There isn't one that I can find. I looked around and saw that a number of packages (such as yi) do just list those three, so I think it's fine.
There was a problem hiding this comment.
For anyone wondering this is the build log for raspberryPi: http://0x0.st/iu-6.txt
|
|
||
| propagatedBuildInputs = [ docopt anytree ]; | ||
|
|
||
| postPatch = '' patchShebangs . ''; |
There was a problem hiding this comment.
what necessitated this?
it seems to work without it (though i am not familiar with this tool)
There was a problem hiding this comment.
here's where I was pointed to when I asked. Apparently it's recommended to catch subtle path-related bugs (which could come up later if new deps are introduced). I don't think it's doing much now but it's also not harming anything.
There was a problem hiding this comment.
the fixupPhase already does this
going by the fact that without this line the wrapped script has a shebang to python in the nix store, i'm guessing it also runs for buildPythonApplication
|
|
| buildPythonApplication rec { | ||
|
|
||
| pname = "catcli"; | ||
| version = "v0.5.13"; |
There was a problem hiding this comment.
| version = "v0.5.13"; | |
| version = "0.5.13"; |
Versions should not include letters.
| src = fetchFromGitHub { | ||
| owner = "deadc0de6"; | ||
| repo = pname; | ||
| rev = version; |
There was a problem hiding this comment.
| rev = version; | |
| rev = "v${version}"; |
As a result of the above.
| homepage = "https://github.com/deadc0de6/catcli"; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ petersjt014 ]; | ||
| platforms = with platforms; [ x86_64-linux aarch64-linux i686-linux ]; |
There was a problem hiding this comment.
Uusually it's fine to just leave this as:
| platforms = with platforms; [ x86_64-linux aarch64-linux i686-linux ]; | |
| platforms = platforms.linux; |
Motivation for this change
It's a neat tool.
Things done
Added the package, included tests found and done automatically by the
buildPythonApplicationfunction. Works with both x86-64 and i686. Aarch64 does not build with pkgsCross for reasons that I'm not sure of yet, but it does build natively.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)