-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-town: 7.2.0 -> 7.3.0 #84080
git-town: 7.2.0 -> 7.3.0 #84080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should a cosmetic change of the code be in a separate commit?
It’s clear enough from the message what changed, I think. (And theres always |
It's not only about "what changed", but also because it makes |
I was just making it look like most other expressions. Which won't have much of an effect. You could argue that it should have been corrected on the initial commit. |
It's not only about "what changed", but also because it makes `git
revert`, `git blame` and `git bisect` less useful. So that's why
usually in development it's considered as a bad practice.
"usually" is quite the weasel word.
I don't see how it meaningfully interferes with revert or bisect, and
blame takes -w to ignore whitespace.
|
If you need to revert, you cannot revert only functional changes, but you'll also revert refactoring. |
> It's not only about "what changed", but also because it makes `git
> revert`, `git blame` and `git bisect` less useful. So that's why
> usually in development it's considered as a bad practice.
"usually" is quite the weasel word.
I don't see how it meaningfully interferes with revert or bisect, and
blame takes -w to ignore whitespace.
I'd like to apologise for this comment. It was unnecessarily rude. I
was feeling upset at the time for other reasons, and I shouldn't have
taken it out on you. I'm sorry.
|
Motivation for this change
just going through r-ryantm logs
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)