Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.03 Markhor art work #49

Merged
merged 2 commits into from Apr 3, 2020
Merged

20.03 Markhor art work #49

merged 2 commits into from Apr 3, 2020

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Apr 2, 2020

No description provided.

@mogorman mogorman mentioned this pull request Apr 2, 2020
@davidak
Copy link
Member

davidak commented Apr 2, 2020

Thanks for creating the artwork again. It looks very good!

I think there is an issue with the perspective. When we assume the parts of the NixOS logo are on the same layer, why is one horn in front of it and the other behind?

The head is turned right, so the left horn should be closer to the viewer and maybe in front of the logo part.

Here is my ugly mockup:

markhor

@mogorman
Copy link
Contributor Author

mogorman commented Apr 2, 2020

i changed it like you requested.

@mogorman
Copy link
Contributor Author

mogorman commented Apr 2, 2020

i think it looks better with whole head through the nixos logo though

@samueldr
Copy link
Member

samueldr commented Apr 2, 2020

SInce it's not obvious from looking at the commits,

It went from:

  • original with "wrong" horn perspective
  • davidak's proposal of the right hown
  • head completely poking through

I do like the head completely poking through. 👍

Thank very much, again, @mogorman !

@worldofpeace if you can approve, this can be merged :).

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I have to agree that the head entirely through is perfect.
Thanks, let's merge this.

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@samueldr samueldr merged commit 8e39b32 into NixOS:master Apr 3, 2020
@mogorman mogorman deleted the markhor branch April 3, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants