Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.17.3 -> 1.18.0 #83984

Merged
merged 1 commit into from Apr 16, 2020
Merged

kubernetes: 1.17.3 -> 1.18.0 #83984

merged 1 commit into from Apr 16, 2020

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Apr 1, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kubernetes/kubernetes/releases.

meta.description for kubernetes is: "Production-Grade Container Scheduling and Management"

meta.homepage for kubernetes is: "https://kubernetes.io"

Updates performed:

  • Version update
  • Quoted meta.homepage for RFC 45

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
kubectl
kubectx
kubernetes

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/p385jskppw4i9qpcn407mr5jbvjvhw3s-kubernetes-1.18.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A kubernetes https://github.com/r-ryantm/nixpkgs/archive/4be26439a0548c7f354916a316f4fce3d324039c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/p385jskppw4i9qpcn407mr5jbvjvhw3s-kubernetes-1.18.0
ls -la /nix/store/p385jskppw4i9qpcn407mr5jbvjvhw3s-kubernetes-1.18.0/bin

cc @johanot @offlinehacker @saschagrunert for testing.

saschagrunert
saschagrunert approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give us some time for manual testing.

I did not see any big changes in the changelogs which could have affect on our side, but I could be wrong for sure.

@bhipple bhipple mentioned this pull request Apr 2, 2020
Closed
@saschagrunert
Copy link
Member

Looks good from my side, can we get this into 20.3? :)

@johanot
Copy link
Contributor

johanot commented Apr 6, 2020

LGTM too. However, one should really take note of this changelog entry in particular when upgrading:

kube-apiserver no longer serves the following deprecated APIs: (#85903, @liggitt)

  • All resources under apps/v1beta1 and apps/v1beta2 - use apps/v1 instead
  • daemonsets, deployments, replicasets resources under extensions/v1beta1 - use apps/v1 instead
  • networkpolicies resources under extensions/v1beta1 - use networking.k8s.io/v1 instead
  • podsecuritypolicies resources under extensions/v1beta1 - use policy/v1beta1 instead

I don't have any feeling of whether it's too late to for this to make it into 20.03. I'll let others decide of that. :) But merge to master, definitely.

@liggitt
Copy link

liggitt commented Apr 6, 2020

Note that those APIs defaulted off in 1.16, and 1.18 makes that default behavior permanent. Unless you were explicitly overriding the defaults to re-enable in 1.16/1.17, this won't affect you.

@johanot
Copy link
Contributor

johanot commented Apr 6, 2020

Thank you for the clarification Jordan!

anmonteiro
anmonteiro approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my AWS cluster and it's working as expected 👍

@srhb srhb merged commit 67413f6 into NixOS:master Apr 16, 2020
@srhb
Copy link
Contributor

srhb commented Apr 16, 2020

LGTM too. Whether this should be backported to 20.03 I'm not sure. I propose that we open an issue and deal with this discussion once and for all. I am inclined to say: Let's leave it up to the release managers for now. Then, for 20.09, add release notes that clarify that NixOS releases will now track the latest major release of kubernetes, even within the stable release, due to the speed at which Kubernetes releases. The alternative, I think, is tracking ~2 kubernetes releases and switching around the default one every major release, but I think that's too much busywork.

@r-ryantm r-ryantm deleted the auto-update/kubernetes branch April 17, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

@johanot johanot Awaiting requested review from johanot

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @saschagrunert @johanot @liggitt @srhb @anmonteiro