Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: update build configuration. #84087

Merged
merged 4 commits into from Apr 2, 2020
Merged

mariadb: update build configuration. #84087

merged 4 commits into from Apr 2, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 2, 2020

Motivation for this change

In release-notes marked deprecated TokuDB plugin.
Added options withStorageRocks and withStorageToku. It is necessary to be able to build MariaDB with jemalloc 5 library. For this, we need to disable TokuDB plugin.
Added zstd compression.

cc @flokli @aanderse @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice April 2, 2020 08:31
flokli
flokli reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small nit, LGTM.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

Please backport to 20.03.

@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

This fails evaluation.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

error - Failed during the setup of executing nix-env: Os { code: 2, kind: NotFound, message: "No such file or directory" }

flokli
flokli reviewed Apr 2, 2020
View reviewed changes
nixos/doc/manual/release-notes/rl-2003.xml Outdated Show resolved Hide resolved
nixos/doc/manual/release-notes/rl-2003.xml Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

I'm personally fine backporting this to 20.03 - both TokuDB and RocksDB are enabled, and having this in 20.03 (and in the release notes) gives users some time to migrate.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg build mariadb.client

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg build mariadb.client

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg eval

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg build mariadb.server

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg build mariadb.server

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg build mariadb.client

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 2, 2020

@GrahamcOfBorg eval

@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

@GrahamcOfBorg test mysql

flokli
flokli approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I very much approve bringing this into 20.03, but want wait feedback from @worldofpeace or @disassembler.

flokli
flokli approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I very much approve bringing this into 20.03, but want wait feedback from @worldofpeace or @disassembler.

worldofpeace
worldofpeace approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this being backported.

@flokli flokli merged commit 44c20fb into NixOS:master Apr 2, 2020
@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

@Izorkin this doesn't seem to apply cleanly on 20.03, even not when I git cherry-pick -x 4b8d66aa7266ab55f08d53271df36832d9c055d2 before. Can you prepare a PR targetet against 20.03 cherry-picking these commits?

@Izorkin Izorkin deleted the mariadb-tokudb branch April 3, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @flokli @worldofpeace