Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guix: init at 1.1.0 #84004

Closed
wants to merge 7 commits into from
Closed

guix: init at 1.1.0 #84004

wants to merge 7 commits into from

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Apr 1, 2020 •
edited

Motivation for this change

Add Guix (in standalone mode only)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bqv

This comment has been minimized.

Sign in to view
@bqv bqv marked this pull request as ready for review April 1, 2020 19:29
jonringer
jonringer reviewed Apr 2, 2020
View reviewed changes
pkgs/development/guile-modules/guile-gcrypt/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-git/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-git/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-git/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-json/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-json/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-sqlite3/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-sqlite3/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-ssh/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-ssh/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

cole-h
cole-h requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I noticed (going through commit-by-commit, so expect more maybe).

pkgs/development/guile-modules/guile-json/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-json/default.nix Outdated Show resolved Hide resolved
pkgs/development/guile-modules/guile-json/default.nix Outdated Show resolved Hide resolved
@doronbehar doronbehar mentioned this pull request Apr 3, 2020
Closed
@bqv
Copy link
Contributor Author

bqv commented Apr 3, 2020

@mbakke informs me elsewhere that 1.1 may imminently be released, will probably hold off on this until then.

@bqv bqv changed the title guix: init at 1.0.1 guix: init at 1.1.0 Apr 16, 2020
@bqv bqv requested a review from FRidh as a code owner April 17, 2020 01:07
@bqv
Copy link
Contributor Author

bqv commented Apr 17, 2020

@FRidh apologies, bad rebase, feel free to escape

@Mic92 Mic92 removed the request for review from FRidh April 17, 2020 14:29
@bqv bqv mentioned this pull request Apr 17, 2020
Closed
10 tasks
@bqv
Copy link
Contributor Author

bqv commented Apr 17, 2020

Deprecated in favour of ^

@bqv bqv closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@cole-h cole-h cole-h requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bqv @jonringer @cole-h