New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/xrdp: refactor #83927
base: master
Are you sure you want to change the base?
modules/xrdp: refactor #83927
Conversation
This pull request depends on #83922 |
- xrdp: 0.9.9 -> 0.9.12 - xrdp: enable additional configure options - xorgxrdp: split into separate package - xorgxrdp: 0.2.9 -> 0.2.12
ee53505
to
7dda48d
Compare
- make configuration more explicit - simplify xrdp package - put configuration to /etc and use `environment.etc` - integrate with nixos xserver sessions - run xrdp and xrdp-sesman as forking daemons - use syslog for logging
7dda48d
to
deef0ee
Compare
@GrahamcOfBorg test xrdp |
@GrahamcOfBorg eval |
@GrahamcOfBorg eval |
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
I marked this as stale due to inactivity. → More info |
Hi, I know this PR is quite old, nevertheless, I wish to see it merged. Do you plan to update it so I can review it asap ? |
Motivation for this change
Improve xrdp nixos module
Things done
environment.etc
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)