modules/hyperv-guest: improvements #83928
Conversation
offlinehacker
force-pushed
the
nixos/hyperv-guest/improvements
branch
from
00a03f6
to
1521479
Compare
- xrdp: 0.9.9 -> 0.9.12 - xrdp: enable additional configure options - xorgxrdp: split into separate package - xorgxrdp: 0.2.9 -> 0.2.12
offlinehacker
force-pushed
the
nixos/hyperv-guest/improvements
branch
from
1521479
to
fbaa3a9
Compare
- make configuration more explicit - simplify xrdp package - put configuration to /etc and use `environment.etc` - integrate with nixos xserver sessions - run xrdp and xrdp-sesman as forking daemons - use syslog for logging
offlinehacker
force-pushed
the
nixos/hyperv-guest/improvements
branch
from
fbaa3a9
to
34f2a5a
Compare
- option to enable xrdp for enchanched session - option to enable x11 - add hyperv_fb driver for xserver - add missing sd_mod and sr_mod kernel modules - load xrdp pulseaudio module on enchanched session mode
offlinehacker
force-pushed
the
nixos/hyperv-guest/improvements
branch
from
34f2a5a
to
5b28292
Compare
| @@ -22,6 +22,18 @@ in { | |||
| Server 2008 R2 or earlier. | |||
| ''; | |||
| }; | |||
|
|
|||
| enchanchedSessionMode = mkOption { | |||
There was a problem hiding this comment.
Cannot use mkEnableOption, since the option is disabled by default.
There was a problem hiding this comment.
mkEnableOption defaults to false too:
mkEnableOption =
# Name for the created option
name: mkOption {
default = false;
example = true;
description = "Whether to enable ${name}.";
type = lib.types.bool;
};
| description = "Whether to enable enchanched session mode."; | ||
| }; | ||
|
|
||
| x11 = mkOption { |
There was a problem hiding this comment.
Cannot use mkEnableOption, since the option is disabled by default.
| description = "xrdp session manager"; | ||
| restartIfChanged = false; # do not restart on "nixos-rebuild switch". like "display-manager", it can have many interactive programs as children | ||
| preStart = '' | ||
| # create run directory | ||
| mkdir -p /run/xrdp |
There was a problem hiding this comment.
serviceConfig.RuntimeDirectory = "xrdp";
| preStart = '' | ||
| # create run directory | ||
| mkdir -p /run/xrdp |
There was a problem hiding this comment.
serviceConfig.RuntimeDirectory = "xrdp";
|
@GrahamcOfBorg eval |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)