xrdp: 0.9.9 -> 0.9.12, refactor #83922
Conversation
- xrdp: 0.9.9 -> 0.9.12 - xrdp: enable additional configure options - xorgxrdp: split into separate package - xorgxrdp: 0.2.9 -> 0.2.12
offlinehacker
force-pushed
the
pkgs/xrdp/improvements
branch
from
6f03422
to
d68135c
Compare
|
@GrahamcOfBorg eval |
|
@volth patch is still there, but I decided to use original source and pass it as patch, so no fork is needed: https://github.com/NixOS/nixpkgs/pull/83922/files#diff-904abce1afc720f5b9832c46b031c81aR19 |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
Please resolve the merge conflict(s). |
|
|
|
There's also this PR #83927 Which one is the right PR? |
SuperSandro2000
added
the
2.status: stale
| substituteInPlace $out/etc/xrdp/sesman.ini --replace /etc/xrdp/pulse $out/etc/xrdp/pulse | ||
|
|
||
| # remove all session types except Xorg (they are not supported by this setup) | ||
| ${perl}/bin/perl -i -ne 'print unless /\[(X11rdp|Xvnc|console|vnc-any|sesman-any|rdp-any|neutrinordp-any)\]/ .. /^$/' $out/etc/xrdp/xrdp.ini |
There was a problem hiding this comment.
| ${perl}/bin/perl -i -ne 'print unless /\[(X11rdp|Xvnc|console|vnc-any|sesman-any|rdp-any|neutrinordp-any)\]/ .. /^$/' $out/etc/xrdp/xrdp.ini | |
| perl -i -ne 'print unless /\[(X11rdp|Xvnc|console|vnc-any|sesman-any|rdp-any|neutrinordp-any)\]/ .. /^$/' $out/etc/xrdp/xrdp.ini |
| ${perl}/bin/perl -i -ne 'print unless /\[(X11rdp|Xvnc|console|vnc-any|sesman-any|rdp-any|neutrinordp-any)\]/ .. /^$/' $out/etc/xrdp/xrdp.ini | ||
|
|
||
| # remove all session types and then add Xorg | ||
| ${perl}/bin/perl -i -ne 'print unless /\[(X11rdp|Xvnc|Xorg)\]/ .. /^$/' $out/etc/xrdp/sesman.ini |
There was a problem hiding this comment.
| ${perl}/bin/perl -i -ne 'print unless /\[(X11rdp|Xvnc|Xorg)\]/ .. /^$/' $out/etc/xrdp/sesman.ini | |
| perl -i -ne 'print unless /\[(X11rdp|Xvnc|Xorg)\]/ .. /^$/' $out/etc/xrdp/sesman.ini |
| }) | ||
| ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig autoconf automake which libtool nasm perl ]; |
There was a problem hiding this comment.
| nativeBuildInputs = [ pkgconfig autoconf automake which libtool nasm perl ]; | |
| nativeBuildInputs = [ pkg-config autoconf automake which libtool nasm perl ]; |
| sha256 = "0fi9bhvykdkwirgcgm5fgkvdzfn983rk077cwyn95pij4xp4g7qb"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig autoconf automake which libtool nasm ]; |
There was a problem hiding this comment.
| nativeBuildInputs = [ pkgconfig autoconf automake which libtool nasm ]; | |
| nativeBuildInputs = [ pkg-config autoconf automake which libtool nasm ]; |
stale
bot
removed
the
2.status: stale
|
Superseded by #209509. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)