Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextdns: init at 1.7.0 #84073

Merged
merged 2 commits into from Aug 8, 2020
Merged

nextdns: init at 1.7.0 #84073

merged 2 commits into from Aug 8, 2020

Conversation

pnelson
Copy link
Contributor

@pnelson pnelson commented Apr 2, 2020

Motivation for this change

Include the NextDNS DNS/53 to DoH Proxy CLI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit April 2, 2020 05:50
Emantor
Emantor approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and correctly resolves google.de on NixOS unstable.

jonringer
jonringer reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

This can be done with:

git reset HEAD~1
git add -- pkgs/
git commit --amend --no-edit
git push ... ... --force

@pnelson pnelson force-pushed the nextdns-1.4.36 branch 2 times, most recently from 7ecc454 to 51c937d Compare April 2, 2020 23:24
@pnelson
Copy link
Contributor Author

pnelson commented Apr 2, 2020

Updated again with build flags to set the version so it doesn't read "dev".

$ result/bin/nextdns version
nextdns version 1.4.36

Ma27
Ma27 requested changes Apr 4, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to write a simple nixos module which installs the service files for systemd.

@pnelson pnelson requested a review from infinisil as a code owner April 4, 2020 23:41
@pnelson pnelson requested a review from Ma27 April 7, 2020 12:34
@pnelson pnelson requested a review from jonringer April 13, 2020 02:00
@pnelson pnelson changed the title nextdns: init at 1.4.36 nextdns: init at 1.5.1 Apr 13, 2020
@pnelson pnelson changed the title nextdns: init at 1.5.1 nextdns: init at 1.5.2 Apr 19, 2020
@pnelson pnelson requested a review from Emantor April 20, 2020 02:25
@pnelson pnelson changed the title nextdns: init at 1.5.2 nextdns: init at 1.5.3 Apr 24, 2020
@pnelson pnelson changed the title nextdns: init at 1.5.3 nextdns: init at 1.5.4 Apr 27, 2020
jonringer
jonringer reviewed May 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do 2 commits:

nextdns: init at 1.5.4
nixos/nextdns: init

cc @infinisil for module review

infinisil
infinisil requested changes May 5, 2020
View reviewed changes
nixos/modules/services/networking/nextdns.nix Show resolved Hide resolved
nixos/modules/services/networking/nextdns.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/nextdns.nix Outdated Show resolved Hide resolved
@pnelson pnelson requested a review from infinisil May 5, 2020 18:56
@pnelson pnelson changed the title nextdns: init at 1.5.4 nextdns: init at 1.6.4 May 30, 2020
@pnelson pnelson requested a review from jonringer May 30, 2020 18:00
@pnelson pnelson requested a review from Ma27 June 17, 2020 17:13
@pnelson pnelson changed the title nextdns: init at 1.6.4 nextdns: init at 1.7.0 Jun 25, 2020
@peterhoeg
Copy link
Member

Thanks for all your hard work on this @pnelson.

@peterhoeg peterhoeg merged commit 4767015 into NixOS:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Emantor Emantor Awaiting requested review from Emantor

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pnelson @peterhoeg @Emantor @Ma27 @jonringer @infinisil