Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 80.0.3987.149 -> 80.0.3987.162 #83956

Merged
merged 1 commit into from Apr 2, 2020
Merged

chromium: 80.0.3987.149 -> 80.0.3987.162 #83956

merged 1 commit into from Apr 2, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 1, 2020 •
edited

https://chromereleases.googleblog.com/2020/03/stable-channel-update-for-desktop_31.html

This update includes 8 security fixes.

CVEs:
CVE-2020-6450 CVE-2020-6451 CVE-2020-6452

Test status
platform attribute status tester
x86_64 chromium ✔️ @danielfullmer
x86_64 nixosTests.chromium ✔️ @danielfullmer
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Apr 1, 2020 •
edited

@thefloweringash: BTW, if you'd optionally like to test chromiumDev on AArch64 you need #83290 and #83350 as well (then it should theoretically work - but no guarantees, I only tested Chromium 82 so far and only on x86_64).

@danielfullmer
Copy link
Contributor

Built and tested chromium and nixosTests.chromium. Manually testing chromium included checking youtube, webgl, and wasm. Those all seem to be working fine.

@thefloweringash
Copy link
Member

LGTM on aarch64, briefly tested general browsing and youtube.

@primeos
Copy link
Member Author

primeos commented Apr 2, 2020

@danielfullmer @thefloweringash awesome, thank you very much :)

@primeos primeos merged commit 7116a88 into NixOS:master Apr 2, 2020
primeos added a commit that referenced this pull request Apr 2, 2020
@primeos
chromiumDev: Remove a patch that is already applied
36c7123 
This fixes the patch phase.
I missed this problem in #83956.
primeos added a commit that referenced this pull request Apr 2, 2020
@primeos
chromiumDev: Remove a patch that is already applied
6997501 
This fixes the patch phase.
I missed this problem in #83956.

(cherry picked from commit 36c7123)
@primeos primeos mentioned this pull request Apr 2, 2020
Merged
10 tasks
@primeos
Copy link
Member Author

primeos commented Apr 2, 2020

A few delayed updates for completeness:

  • chromiumDev did unfortunately break again (version 82 was working on x86_64) - I already pushed 36c7123 but I'll probably wait for Staging next #83618 with the second fix to avoid unnecessary complications
  • Backport for 20.03: bb34ef3

primeos added a commit to primeos/nixpkgs that referenced this pull request Apr 8, 2020
@primeos
chromiumDev: Remove a patch that is already applied
631a5ef 
This fixes the patch phase.
I missed this problem in NixOS#83956.

(cherry picked from commit 36c7123)
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@primeos @stigok
chromiumDev: Remove a patch that is already applied
b5732da 
This fixes the patch phase.
I missed this problem in NixOS#83956.

(cherry picked from commit 36c7123)
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 2.status: work-in-progress 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @danielfullmer @thefloweringash @TredwellGit