Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rkdeveloptool: 1.3 -> unstable-2019-07-01 #84034

Merged
merged 1 commit into from Apr 4, 2020
Merged

rkdeveloptool: 1.3 -> unstable-2019-07-01 #84034

merged 1 commit into from Apr 4, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Apr 1, 2020 •
edited

ZHF: #80379
https://hydra.nixos.org/build/115533412

Fixed build by bumping to latest upstream rockchip-linux/rkdeveloptool@6e92ebc

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lopsided98 April 1, 2020 21:08
lopsided98
lopsided98 suggested changes Apr 1, 2020
View reviewed changes
pkgs/misc/rkdeveloptool/default.nix Outdated Show resolved Hide resolved
@stigtsp
rkdeveloptool: 1.3 -> unstable-2019-07-01
9531fba 
Bumped to upstream commit 6e92ebcf8b1812da02663494a68972f956e490d3
@stigtsp stigtsp force-pushed the package/rkdeveloptool-1.3-62 branch from e52484a to 9531fba Compare April 2, 2020 11:32
@stigtsp stigtsp changed the title rkdeveloptool: 1.3 -> 1.3-62 rkdeveloptool: 1.3 -> unstable-2019-07-01 Apr 2, 2020
@lopsided98
Copy link
Contributor

@GrahamcOfBorg build rkdeveloptool

@bhipple
Copy link
Contributor

bhipple commented Apr 4, 2020 •
edited

@GrahamcOfBorg build rkdeveloptool

@GrahamcOfBorg eval

bhipple
bhipple approved these changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 84034 1

1 package built: - rkdeveloptool

@bhipple bhipple merged commit 299672a into NixOS:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@lopsided98 lopsided98 lopsided98 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @lopsided98 @bhipple