minijail: support compiling policies to BPF #83477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from the android-* tags to the linux-* ones, because Upstream says "Releases are tagged as `linux-vXX`".
This is built from the same source as minijail, but is for all intents and purposes a seperate package. It builds different things, with no overlap, and is under a different license.
This is a syscall table used for compiling Minijail policy files to BPF. The compiler is available in the minijail-tools package. The file is generated by compiling and running a small program named dump_constants. When cross-compiling, we have to get the syscall table for the host platform. To do this, dump_constants is run under QEMU user emulation for the appropriate platform. Google takes the same approach in their minijail packages for ChromiumOS[1]. [1]: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/729bd4269a47870380f8dde0b162de355ce89dfe/chromeos-base/minijail/minijail-9999.ebuild#49
ehmry
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I plan to use this in crosvm. This is required for build crosvm HEAD, but fails on the crosvm in the current Chromium OS release. So I’ll wait until a new crosvm is released to integrate it there. But it’s good to have support in minijail anyway.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)