Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/geoclue2: set location.provider to geoclue2" #83933

Merged
merged 1 commit into from Apr 1, 2020
Merged

Revert "nixos/geoclue2: set location.provider to geoclue2" #83933

merged 1 commit into from Apr 1, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 1, 2020 •
edited

Motivation for this change

This reverts commit f8a78af

fixes ofBorg

closes #83929

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

I'm about to go to sleep, going to merge this to unbreak CI

@jonringer jonringer merged commit 3459038 into NixOS:master Apr 1, 2020
@jonringer jonringer deleted the fix-borg branch April 1, 2020 08:18
@Ma27
Copy link
Member

Ma27 commented Apr 1, 2020

Also backported as 98c6f66. release-20.03 was affected as well.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OfBorg down
2 participants
@jonringer @Ma27