Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdenlive: set run-time dep paths (fix #83885) #83932

Merged
merged 1 commit into from Apr 1, 2020
Merged

kdenlive: set run-time dep paths (fix #83885) #83932

merged 1 commit into from Apr 1, 2020

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Apr 1, 2020 •
edited

Motivation for this change

See #83885 and #29614. Without these fixes, at least for me, kdenlive was complaining on the command line that it doesn't find ffmpeg nor frei0r. Not sure if it had any real effect on the program otherwise though, but at least those suspicious warnings.

Fixes #83885.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from ttuegel as a code owner April 1, 2020 06:46
@jluttine
Copy link
Member Author

jluttine commented Apr 1, 2020

I don't understand the check failure: Failed during the setup of executing nix-env: Os { code: 2, kind: NotFound, message: "No such file or directory" }.

And regarding the missing speed effect: I found speed adjustments by right clicking a clip on the timeline.

@Mic92 Mic92 merged commit 5853515 into NixOS:master Apr 1, 2020
@jtojnar jtojnar mentioned this pull request Jun 10, 2020
Closed
@tobiasBora
Copy link
Contributor

Thanks for this PR, but could this be backported to the stable branch? This error is still here on 20.03, but if I install kdenlive from unstable it works greatly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kdenlive doesn't find effects
3 participants
@jluttine @tobiasBora @Mic92