Skip to content

bazel-*: Consistently self reference #84028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

bazel-*: Consistently self reference #84028

merged 2 commits into from
Apr 1, 2020
+17 −12

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Using bazel_self for self-references makes managing bazel versions
easier: their less risk of changing defaults or copy pasted code for no
versions leading to incorrect self-references.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314 Ericson2314 requested a review from Profpatsch as a code owner April 1, 2020 20:15
@Ericson2314
bazel-*: Consistently self reference
6f94f8f 
Using `bazel_self` for self-references makes managing bazel versions
easier: their less risk of changing defaults or copy pasted code for no
versions leading to incorrect self-references.
@Ericson2314
Merge remote-tracking branch 'upstream/master' into consistent-bazel-ref
6bf6ec8
@Ericson2314 Ericson2314 force-pushed the consistent-bazel-ref branch from 1da1991 to 6bf6ec8 Compare April 1, 2020 20:16
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 1, 2020
@ofborg ofborg bot requested a review from mboes April 1, 2020 20:23
@Ericson2314 Ericson2314 merged commit a5480d0 into NixOS:master Apr 1, 2020
@Ericson2314 Ericson2314 mentioned this pull request Apr 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch

@mboes mboes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ericson2314