Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-compute-engine-oslogin: fix bash reference #83960

Merged
merged 1 commit into from Apr 1, 2020
Merged

google-compute-engine-oslogin: fix bash reference #83960

merged 1 commit into from Apr 1, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Apr 1, 2020 •
edited

Motivation for this change

Fix the login experience when using OSLogin. The user was running the non-interactive version of bash which leads to a broken prompt and no tab completion or readline support in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
google-compute-engine-oslogin: fix bash reference
4ebd229 
This is the bash that is being called when logging into the VM. This
fixes prompt escaping issues and also restores tab completion to the
logged-in user.
@zimbatm zimbatm requested a review from flokli April 1, 2020 11:22
@ofborg ofborg bot requested a review from adisbladis April 1, 2020 11:37
@flokli flokli merged commit e1da6c1 into NixOS:master Apr 1, 2020
@zimbatm zimbatm deleted the google-compute-engine-oslogin-fix branch April 1, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @flokli