Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/virtualisation: add hyperv-image #83930

Merged
merged 1 commit into from Apr 14, 2020
Merged

modules/virtualisation: add hyperv-image #83930

merged 1 commit into from Apr 14, 2020

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

This module implements builder for hyper-v images.

Testing

Use the following command to build hyper-v image:

NIXOS_CONFIG=$PWD/nixos/modules/virtualisation/hyperv-image.nix nix-build nixos -A config.system.build.hypervImage

After that import resulting vhdx file into hyper-v and do not forget to disable secure boot.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker
modules/virtualisation: add hyperv-image
54b04af 
This module implements builder for hyper-v images.
@Mic92
Copy link
Member

Mic92 commented Apr 1, 2020

Might be also worth adding to: https://github.com/nix-community/nixos-generators

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@offlinehacker
Copy link
Contributor Author

@Mic92 I can add it after this pull request is merged 🙂

jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no testing, but diff LGTM

@offlinehacker offlinehacker merged commit de6891f into NixOS:master Apr 14, 2020
@evanjs evanjs mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @Mic92 @jonringer