Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect /nix-dev to new location #377

Merged
merged 2 commits into from Apr 4, 2020
Merged

redirect /nix-dev to new location #377

merged 2 commits into from Apr 4, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 2, 2020

No description provided.

@garbas garbas requested a review from edolstra April 2, 2020 00:35
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2020

🚀 Deployed on https://5e8533cb4041f55bca0e9ed5--nixos-homepage.netlify.com

garbas
garbas commented Apr 2, 2020
View reviewed changes
netlify.toml
@@ -10,6 +10,12 @@
status = 302
force = true

[[redirects]]
from = "/nix-dev/*"
to = "https://releases.nixos.org/nix-dev/:splat"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edolstra In this PR I'm assuming that I will upload nix-dev to nix-releases bucket. Would it be better to create new bucket for this eg. old.nixos.org or archive.nixos.org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is in another bucket, I still strongly suggest suffixing with /nix-dev/:splat so we can archive more things as required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's use releases.nixos.org. Otherwise we'll have to set up another bucket + Cloudfront distribution + DNS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider it done

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/announcement-moving-nixos-org-to-netlify/6212/41

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/announcement-moving-nixos-org-to-netlify/6212/42

@garbas garbas added this to Confirmed in TODO Apr 4, 2020
@garbas garbas self-assigned this Apr 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2020

🚀 Deployed on https://5e87eea0f6dd610407b6ef66--nixos-homepage.netlify.com

@garbas garbas merged commit e9bdf28 into master Apr 4, 2020
@garbas garbas deleted the nix-dev-redirect branch April 4, 2020 02:35
@garbas garbas moved this from Confirmed to Done in TODO Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees

@garbas garbas

Labels
None yet
Projects
TODO
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garbas @nixos-discourse @samueldr @edolstra