Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: add freedesktop/gnome/myself maintainers #84059

Merged
merged 1 commit into from Apr 2, 2020
Merged

nixos: add freedesktop/gnome/myself maintainers #84059

merged 1 commit into from Apr 2, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assuming ofborg checkmeta passes

@worldofpeace
Copy link
Contributor Author

@jonringer Does it eval drafts? (can't remember, been a while since I did a draft)

@worldofpeace worldofpeace marked this pull request as ready for review April 2, 2020 00:29
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 2, 2020 •
edited

I guess not.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

ofborg has been touchy recently.

@worldofpeace worldofpeace mentioned this pull request Apr 2, 2020
Merged
@jonringer
Copy link
Contributor

ah, see #84058 (comment)

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: module (update) labels Apr 2, 2020
@jonringer
Copy link
Contributor

you can also do meta check locally if you follow https://github.com/NixOS/ofborg#running-meta-checks-locally

@worldofpeace
Copy link
Contributor Author

you can also do meta check locally if you follow https://github.com/NixOS/ofborg#running-meta-checks-locally

hehe, that thing uses way too much memory.

@worldofpeace worldofpeace merged commit 7f6dda7 into NixOS:master Apr 2, 2020
@worldofpeace worldofpeace deleted the teams-nixos branch April 2, 2020 01:22
@worldofpeace
Copy link
Contributor Author

Thanks @jonringer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jonringer @jtojnar