Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing: 1.4.2 -> 1.5.0, install desktop menu link to GUI #83974

Closed
wants to merge 2 commits into from
Closed

syncthing: 1.4.2 -> 1.5.0, install desktop menu link to GUI #83974

wants to merge 2 commits into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Apr 1, 2020

Motivation for this change

Manually opening http://127.0.0.1:8384/ in a browser is tedious, moreso if you have to talk someone else through it. Create an freedesktop application entry so that users can discover and open the Syncthing GUI page.

As far as I know we don't do this for any other services that serve a webgui, but I think its gives NixOS a more polished feel. We are able do this where other distros cannot, because we can be sure of where the GUI is bound.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry changed the title nixos/syncthing: install desktop menu link to GUI syncthing: 1.4.2 -> 1.5.0, install desktop menu link to GUI May 5, 2020
@peterhoeg
Copy link
Member

1.5.0 is already in master, hence the merge conflict.

@bhipple
Copy link
Contributor

bhipple commented Jul 6, 2020

syncthing: 1.4.2 -> 1.5.0 is already done; if you'd still like to do the desktop shortcuts let's do so in another PR, as the upgrade portion here is no longer relevant.

@bhipple bhipple closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@andrew-d andrew-d Awaiting requested review from andrew-d

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehmry @peterhoeg @bhipple @teto