Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: Switch from gnome3.maintainers to lib.teams.gnome #83975

Merged
merged 1 commit into from
Apr 2, 2020
Merged

tree-wide: Switch from gnome3.maintainers to lib.teams.gnome #83975

merged 1 commit into from
Apr 2, 2020
+186 −191

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Apr 1, 2020

No description provided.

@jtojnar jtojnar requested review from hedning and worldofpeace April 1, 2020 12:45
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 1, 2020
worldofpeace
worldofpeace suggested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things I found to be missing

  • vala
  • glib
  • graphene
  • gtk
  • gtk-doc

All the gnome modules

@jtojnar
Copy link
Member Author

jtojnar commented Apr 1, 2020

I only switched from the old attribute here since it blocks its removal. Tweaking the attributes needs to be done manually so I will leave it to next update of the expressions.

worldofpeace
worldofpeace approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR for nixos coming.

@worldofpeace worldofpeace merged commit 7d91eb2 into NixOS:staging Apr 2, 2020
@worldofpeace
Copy link
Contributor

#84059

@jtojnar jtojnar deleted the gnome-team branch September 2, 2020 22:03
@bobby285271 bobby285271 mentioned this pull request Aug 20, 2021
Merged
12 tasks
@bobby285271 bobby285271 mentioned this pull request Sep 18, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@hedning hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace