Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpg123: add conplay script #84069

Merged
merged 1 commit into from Sep 24, 2020
Merged

mpg123: add conplay script #84069

merged 1 commit into from Sep 24, 2020

Conversation

justinlovinger
Copy link
Contributor

Motivation for this change

Available in the 'conplay' output of 'mpg123'.
'conplay' can seamlessly play audio books using mpg123.
The 'conplay' script is included in the scripts/ directory of mpg123, but was previously not included in the package output.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@justinlovinger
mpg123: add conplay script
d0ca800 
Available in the 'conplay' output.
'conplay' can seamlessly play audio books using mpg123.
@ofborg ofborg bot requested a review from ftrvxmtrx April 2, 2020 03:55
doronbehar
doronbehar approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and diff LGTM. conplay script doesn't accept --help but seems to be working.

@doronbehar doronbehar merged commit 2f3cee6 into NixOS:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@ftrvxmtrx ftrvxmtrx Awaiting requested review from ftrvxmtrx

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinlovinger @doronbehar