Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentx: 2.3.5 -> 2.3.7 #84046

Merged
merged 1 commit into from Apr 1, 2020
Merged

opentx: 2.3.5 -> 2.3.7 #84046

merged 1 commit into from Apr 1, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates opentx to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @elitak

@ofborg ofborg bot requested a review from elitak April 1, 2020 22:55
jonringer
jonringer approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/84046
1 package built:
opentx

@jonringer jonringer merged commit 9574d98 into NixOS:master Apr 1, 2020
@lopsided98 lopsided98 deleted the opentx-update branch April 1, 2020 23:57
@elitak
Copy link
Contributor

elitak commented Apr 2, 2020

I get a hash mismatch on the 2.3.5.tar.gz's contents. Can you double-check the tag didn't change upstream?

@jonringer
Copy link
Contributor

are you on darwin?

@jonringer
Copy link
Contributor 

[17:26:00] jon@jon-desktop /home/jon/projects/nixpkgs (master)
$ nix-build -A opentx.src --check
checking outputs of '/nix/store/6fd30k0x0j9wy80kjbzqfrghr4jvi8xk-source.drv'...

trying https://github.com/opentx/opentx/archive/release/2.3.7.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   128    0   128    0     0    384      0 --:--:-- --:--:-- --:--:--   385
100 18.8M    0 18.8M    0     0  2899k      0 --:--:--  0:00:06 --:--:-- 3475k
unpacking source archive /build/2.3.7.tar.gz
/nix/store/7hz9dp5y5shpfgjbmz4jnd44nhfsqw37-source
[17:26:19] jon@jon-desktop /home/jon/projects/nixpkgs (master)

@lopsided98
Copy link
Contributor Author

The hash mismatch is with 2.3.5 (the old version). It seems like they changed the tag; Arch Linux has the same issue: https://aur.archlinux.org/packages/opentx-companion/#comment-735345

@jonringer
Copy link
Contributor

ah, interesting

@elitak
Copy link
Contributor

elitak commented Apr 2, 2020

Oh, oops. I checked out your opentx-update branch but didn't look carefully at the version numbers, and was trying to build your commit from last time you updated the package.
I guess you deleted that branch and I had the old HEAD of it still. I can't find this latest commit. Anyway, if it builds and runs I'm sure it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@elitak elitak Awaiting requested review from elitak

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @elitak @jonringer