Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: fix setup-hook #84044

Closed
wants to merge 1 commit into from
Closed

emacs: fix setup-hook #84044

wants to merge 1 commit into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Apr 1, 2020

This change fixes byte compilation of, e.g., Helm without breaking builds using, e.g., trivialBuild.

See #82604 (comment)

@rycee
emacs: fix setup-hook
d3eeaec 
This change fixes byte compilation of, e.g., Helm without breaking
builds using, e.g., `trivialBuild`.

See NixOS#82604 (comment)
@thefloweringash
Copy link
Member

I've confirmed that helm is successfully byte compiled. LGTM.

@rycee
Copy link
Member Author

rycee commented Apr 2, 2020 •
edited

Thanks for testing! Rebased to master in bf486f7.

@rycee rycee closed this Apr 2, 2020
@rycee rycee deleted the fix-emacs-setup-hook branch April 2, 2020 21:07
@cprussin cprussin mentioned this pull request Apr 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @thefloweringash