Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: mass unmark non-broken packages #84039

Merged
merged 1 commit into from Apr 3, 2020
Merged

haskellPackages: mass unmark non-broken packages #84039

merged 1 commit into from Apr 3, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Apr 1, 2020

Motivation for this change

I checked through haskellPackages looking for packages that were
marked as broken, but successfully built.

I identified these 162 packages that were marked as broken in spite of
building successfully for me with NIXPKGS_ALLOW_BROKEN.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
haskellPackages: mass unmark non-broken packages
ce7d3f6 
I checked through haskellPackages looking for packages that were
marked as broken, but successfully built.

I identified these 162 packages that were marked as broken in spite of
building successfully for me with NIXPKGS_ALLOW_BROKEN.
@alyssais alyssais requested a review from peti April 1, 2020 22:07
@cdepillabout
Copy link
Member

@alyssais Thanks for putting in the work to do this!

Do you have a script somewhere that you used to do this?

This looks good to me, but I'll defer to @peti to actually merge it in.

@cdepillabout cdepillabout mentioned this pull request Apr 2, 2020
Closed
10 tasks
@alyssais
Copy link
Member Author

alyssais commented Apr 2, 2020 via email

@peti peti merged this pull request into NixOS:haskell-updates Apr 3, 2020
@alyssais alyssais deleted the haskell-broken branch April 4, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @cdepillabout @peti