Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulip: 4.0.0 -> 5.0.0 #84067

Merged
merged 1 commit into from Apr 6, 2020
Merged

zulip: 4.0.0 -> 5.0.0 #84067

merged 1 commit into from Apr 6, 2020

Conversation

alevy
Copy link
Contributor

@alevy alevy commented Apr 2, 2020 •
edited

Motivation for this change

Zulip 5.0 fixes multiple security issues https://blog.zulip.org/2020/04/01/zulip-desktop-5-0-0-security-release/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alevy
Copy link
Contributor Author

alevy commented Apr 2, 2020

FYI, I was not able to run nix path-info -S without an error (I'm sure I'm invoking it incorrectly), and nix-shell -p nixpkgs-review --run "nixpkgs-review wip" dropped me into a nix-shell with a bunch of files I didn't know how to make left and right of.

I'm happy to try to complete these tests, but just wasn't able to find documentation on them

@ofborg ofborg bot requested a review from jonafato April 2, 2020 02:53
jonafato
jonafato approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jonafato jonafato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran zulip via nixpkgs-review. The app launches and seems to work just fine.

@alevy
Copy link
Contributor Author

alevy commented Apr 5, 2020

Is there more to the process for this to be merged? Or just waiting for some sort of roll-up?

@ryantm ryantm merged commit 946576d into NixOS:master Apr 6, 2020
@ryantm
Copy link
Member

ryantm commented Apr 6, 2020

  • built on NixOS
  • nix-review passed
  • tested basic help messages of all binaries
  • leaf package
  • checked OfBorg all green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonafato jonafato jonafato approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alevy @ryantm @jonafato @Janik-Haag