Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/none: remove #84037

Merged
merged 1 commit into from Apr 2, 2020
Merged

nixos/none: remove #84037

merged 1 commit into from Apr 2, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

This windowManager and desktopManager doesn't even have
an option to use it. git history suggests to me that there's no way anyone
finds this useful anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This windowManager and desktopManager doesn't even have
an option to use it. git history suggests to me that there's no way anyone
finds this useful anymore.
@worldofpeace worldofpeace merged commit ed07380 into NixOS:master Apr 2, 2020
@worldofpeace worldofpeace deleted the remove-none.nix branch April 2, 2020 02:00
@emmanuelrosa
Copy link
Contributor

This change causes an error:

building the system configuration...
trace: Default graphical session, 'xmonad', not found.
Valid names for 'services.xserver.displayManager.defaultSession' are:
  

trace: Default graphical session, 'xmonad', not found.
Valid names for 'services.xserver.displayManager.defaultSession' are:
  

error: The option value `services.xserver.displayManager.defaultSession' in `/etc/nixos/configuration.nix' is not of type `session name'.
(use '--show-trace' to show detailed location information)

I've tried using both "none+xmonad" and "xmonad" as the defaultSession:

  services.xserver = {
     enable = true;
     windowManager.xmonad = {
       enable = true;   
     };

    displayManager.defaultSession = "xmonad";
    displayManager.lightdm = {
	enable = true;
     };
  };

@emmanuelrosa
Copy link
Contributor

I tested reverting the change and setting defaultSession to "none+xmonad" and it worked.

@worldofpeace
Copy link
Contributor Author

I reverted it. I'm wondering is it that none gets imported default so a none desktop manager is somehow always an option 😕 (but it isn't a select-able?)

In that case, I should really add a comment here because the files look like lost fragments that are very often in nixpkgs.

@emmanuelrosa
Copy link
Contributor

My understanding is that the selectable sessions are generated by combining every enabled window manager with every enabled desktop manager; the Cartesian product of desktop and window managers. But with the caveat that the combination of "none+none" is ignored, which is why there's no "none" session available.

# We will generate every possible pair of WM and DM.

@orivej
Copy link
Contributor

orivej commented Apr 2, 2020

In my case this (bisected) caused a different error: after a successful switch to the new configuration, sddm does not list the available sessions (in the lower left corner) and does not launch any session when I login (one of my users uses stock plasma5, another custom .xsession). My configuration is:

services.xserver.displayManager.sddm.enable = true;
services.xserver.desktopManager.plasma5.enable = true;

@arcnmx
Copy link
Member

arcnmx commented Apr 2, 2020

In my case this change made it impossible to login with lightdm because /nix/store/XXXX-desktops/share/xsessions was empty:

[+68.72s] DEBUG: Seat seat0: Failed to find session configuration xsession
[+68.72s] DEBUG: Seat seat0: Can't find session 'xsession'

@xaverdh
Copy link
Contributor

xaverdh commented Apr 2, 2020

I just stumbled upon this after my system failed to evaluate due to sessionPackages being empty. Maybe it should be documented in nixos/modules/services/x11/desktop-managers/none.nix that the crossList logic requires it to be present?

@worldofpeace
Copy link
Contributor Author

I will look into making it appear more idiomatic. But it's been reverted already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants