Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virglrenderer: 0.7.0 -> 0.8.1 #79680

Merged
merged 1 commit into from Feb 20, 2020
Merged

virglrenderer: 0.7.0 -> 0.8.1 #79680

merged 1 commit into from Feb 20, 2020

Conversation

alyssais
Copy link
Member

Motivation for this change

freedesktop.org tarballs haven't been published since 0.7.0. I've
sent a message to the mailing list (87eev3cgcz.fsf@alyssa.is),
suggesting newer tarballs be published.

Build system has changed from autoconf to meson+cmake/ninja, and the
vtest/util.c patch doesn't seem to be necessary any more.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
virglrenderer: 0.7.0 -> 0.8.1
61a3b35 
freedesktop.org tarballs haven't been published since 0.7.0.  I've
sent a message to the mailing list (<87eev3cgcz.fsf@alyssa.is>),
suggesting newer tarballs be published.

Build system has changed from autoconf to meson+cmake/ninja, and the
vtest/util.c patch doesn't seem to be necessary any more.
@alyssais alyssais requested a review from xeji February 10, 2020 02:47
jonringer
jonringer approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[23 built, 113 copied (756.4 MiB), 145.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79680
1 package blacklisted:
tests.nixos-functions.nixosTest-test

20 package built:
aqemu cloud-init cloud-utils libguestfs libguestfs-with-appliance minikube out-of-tree python27Packages.guestfs python37Packages.guestfs python38Packages.guestfs qemu qemu-utils qemu_kvm qemu_test qemu_xen qemu_xen-light qemu_xen_4_10 qemu_xen_4_10-light vagrant virglrenderer

@alyssais alyssais merged commit 14d6777 into NixOS:master Feb 20, 2020
@alyssais alyssais deleted the virgl branch February 20, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @jonringer