Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: fix build #79616

Merged
merged 2 commits into from Feb 9, 2020
Merged

nix: fix build #79616

merged 2 commits into from Feb 9, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 9, 2020 •
edited

Motivation for this change

The recent aws-checksums bump #78563 changed the cmake configuration awslabs/aws-checksums@343a0b0

See: https://hydra.nixos.org/build/111932885

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra February 9, 2020 12:32
@FRidh FRidh added this to the 20.03 milestone Feb 9, 2020
@worldofpeace worldofpeace merged commit fa74455 into NixOS:master Feb 9, 2020
@worldofpeace
Copy link
Contributor

Thanks for the quick response @marsam

@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

aws-sdk-cpp also needs the fix it seems

worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Feb 9, 2020
@worldofpeace
aws-sdk-cpp: build shared libraries
21b371b 
Same fix as NixOS#79616
@worldofpeace worldofpeace mentioned this pull request Feb 9, 2020
Closed
10 tasks
@marsam marsam deleted the fix-nix-build branch May 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @worldofpeace @FRidh