Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creep: split outputs in out and otb #79641

Merged
merged 1 commit into from Feb 14, 2020
Merged

creep: split outputs in out and otb #79641

merged 1 commit into from Feb 14, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 9, 2020

Motivation for this change

Issue #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested fonts are working in X11 and GTK application
  • Tested compilation of all pkgs that depend on this change using
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj mentioned this pull request Feb 9, 2020
Closed
19 tasks
@ofborg ofborg bot requested a review from buffet February 9, 2020 18:24
buffet
buffet approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@buffet buffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 14, 2020

Tested everything a final time.

@rnhmjoj rnhmjoj merged commit b2314a6 into NixOS:master Feb 14, 2020
@rnhmjoj rnhmjoj deleted the creep branch April 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffet buffet buffet approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @buffet