Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipman: 1.2.0 -> unstable-2019-12-10 #79606

Merged
merged 1 commit into from Feb 11, 2020
Merged

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented Feb 9, 2020

Motivation for this change

clipman support for bemenu was added in December 2019, but no release has been created since then. The aim of this pull-request is to upgrade clipman up until a more recent changeset that provides this feature.
I'm not sure whether I should update the version number or leave it as is, could you please clarify ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
Copy link
Member

Please use the standard naming scheme for this, clipman-unstable-YYYY-MM-DD

@k0ral k0ral changed the title clipman: 1.2.0 -> c57453be9 clipman: 1.2.0 -> unstable-2019-12-10 Feb 9, 2020
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we update something to a git rev that doesn't point to a release, using the yyyy-mm-dd notation is the way to go :)

@Ma27 Ma27 merged commit 053006e into NixOS:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants