Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/syncoid: automatically setup privilege delegation #79759

Merged
merged 1 commit into from Oct 25, 2020
Merged

nixos/syncoid: automatically setup privilege delegation #79759

merged 1 commit into from Oct 25, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Follow up to #72060. Runs syncoid as an unprivileged user by default and automatically sets up ZFS privilege delegation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @infinisil

@lopsided98 lopsided98 mentioned this pull request Feb 10, 2020
Merged
10 tasks
@aanderse aanderse requested a review from Mic92 March 8, 2020 13:25
Mic92
Mic92 requested changes Mar 9, 2020
View reviewed changes
nixos/tests/sanoid.nix Outdated Show resolved Hide resolved
nixos/tests/sanoid.nix Outdated Show resolved Hide resolved
@lopsided98 lopsided98 mentioned this pull request Apr 1, 2020
Closed
10 tasks
@numinit numinit self-requested a review September 4, 2020 05:53
numinit
numinit approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@numinit numinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. Feel free to request me as a reviewer for any ZFS-related changes.

@bhipple
Copy link
Contributor

bhipple commented Oct 25, 2020

Result of nixpkgs-review pr 79759 1

1 package blacklisted:
- tests.nixos-functions.nixos-test

@bhipple bhipple merged commit f98312f into NixOS:master Oct 25, 2020
@lopsided98 lopsided98 deleted the syncoid-no-root branch October 25, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 requested changes

@numinit numinit numinit approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @bhipple @Mic92 @numinit