New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openttd_version: OpenTTD var 21/1A result has changed since OpenTTD moved to git #80
Comments
The SVN revision bits are frozen to one past the last SVN revision number, they are not zero. |
So is any change needed, other than updating nml docs? |
I doubt it. See also OpenTTD/OpenTTD#6843 |
So note here that svn version is no longer useful after a specific OpenTTD rev (which?) https://newgrf-specs.tt-wiki.net/wiki/NML:General |
r28004 seems the last SVN rev. I added as much to the wiki... not sure what OpenTTD code says though. |
Yes, 28004 is the hardcoded "final" SVN revision. |
Thanks, so the nml docs are accurate "only valid until OpenTTD r28004 / 1.9.0. In later versions the revision is fixed". The wording there could be improved for clarity, I'll do that now. |
Done |
See https://newgrf-specs.tt-wiki.net/wiki/GlobalVariables#OpenTTD_Version_.2821_.2F_A1.29
When OpenTTD was versioned using SVN the lower bits of var 21/A1 contained the SVN revision. Since OpenTTD 1.9 these bits are unused.
nml has openttd_version var. It also has a built-in function version_openttd(MAJOR, MINOR, BUILD, REVISION) which can test for a specific svn version of OpenTTD. That won't return valid results with OpenTTD >= 1.9
The text was updated successfully, but these errors were encountered: