Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet: add framework doc #78719

Merged
merged 1 commit into from Feb 10, 2020
Merged

dotnet: add framework doc #78719

merged 1 commit into from Feb 10, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes: #78054

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-cant-i-install-dotnet-in-my-rust-build-environment-shell/5786/1

@jonringer jonringer marked this pull request as ready for review February 10, 2020 02:56
@jonringer
Copy link
Contributor Author

I would like this merged before the 20.03 freeze, I think it could be improved, but it's better than having 0 documentation.

@jonringer jonringer merged commit 519519b into NixOS:master Feb 10, 2020
@jonringer jonringer deleted the dotnet-docs branch February 10, 2020 03:54
@101100
Copy link
Contributor

101100 commented Feb 11, 2020

If I just want to have dotnet installed at the OS level on my development machine, this documentation does not make it clear what to do. I'm assuming that this whole section can go in environment.systemPackages, but the documentation is not clear on it...

(with dotnetCorePackages; combinePackages [
      sdk_3_1
      sdk_3_0
      sdk_2_1
    ])

@jonringer
Copy link
Contributor Author

That is correct, the combinePackages will create a new derivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dotnet documentation
4 participants
@jonringer @nixos-discourse @101100 @aanderse