Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcached: fix darwin build #79684

Merged
merged 1 commit into from Feb 10, 2020
Merged

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Fix the build on Darwin.

I made the patch unconditional since it's a general problem detecting the presence of htonll and could affect other platforms. It's also going to be included upstream, see memcached/memcached#598

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 10, 2020
@veprbl
Copy link
Member

veprbl commented Feb 10, 2020

@GrahamcOfBorg build memcached

@veprbl veprbl merged commit 085683c into NixOS:master Feb 10, 2020
@thefloweringash thefloweringash deleted the memcached-fix-darwin branch February 10, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants