Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ispc: 1.10.0 -> 1.12.0 #79746

Closed
wants to merge 1 commit into from
Closed

ispc: 1.10.0 -> 1.12.0 #79746

wants to merge 1 commit into from

Conversation

athas
Copy link
Contributor

@athas athas commented Feb 10, 2020

Motivation for this change

newer=better

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from aristidb February 10, 2020 17:13
alyssais
alyssais requested changes Mar 12, 2020
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the checksum. This won’t actually have changed anything.

@athas
Copy link
Contributor Author

athas commented Mar 13, 2020

Ah, right, of course. That gave rise to some more problems that I had to address (#39687 is relevant).

@athas athas requested a review from alyssais April 16, 2020 22:17
@athas
Copy link
Contributor Author

athas commented Apr 24, 2020

Superceded by #85946.

@athas athas closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristidb aristidb Awaiting requested review from aristidb

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@athas @alyssais