New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 Packages - digi-xbee and srp #79688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 3 commits
maintainers: add jefflabonte
pythonPackages.digi-xbee: init at 1.3.0
pythonPackages.srp: init at 1.0.15
f35cfd9
to
c6fb08b
Compare
e478c91
to
8af9c97
Compare
Yup, I changed my commit messages |
e478c91
to
717447c
Compare
717447c
to
29cc593
Compare
Everything should resolved right now. Thank you for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid:
arning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/c7nw0sfjgdhv66d1fa9rvny5k4h4f26r-python2.7-digi-xbee-1.3.0.drv' failed with exit code 1; last 10 log lines:
adding 'digi_xbee-1.3.0.dist-info/top_level.txt'
adding 'digi_xbee-1.3.0.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/build/digi-xbee-1.3.0/dist /build/digi-xbee-1.3.0
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Processing ./digi_xbee-1.3.0-py2-none-any.whl
ERROR: Package 'digi-xbee' requires a different Python: 2.7.17 not in '>=3'
cannot build derivation '/nix/store/4gcrahskwpprqz9xs7p8wpsfd28xjrv2-env.drv': 1 dependencies couldn't be built
[7 built (1 failed), 3 copied (1.6 MiB), 0.3 MiB DL]
error: build of '/nix/store/4gcrahskwpprqz9xs7p8wpsfd28xjrv2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79688
1 package failed to build:
python27Packages.digi-xbee
29cc593
to
f839c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
[6 built, 2 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79688
5 package built:
python27Packages.srp python37Packages.digi-xbee python37Packages.srp python38Packages.digi-xbee python38Packages.srp
would like more tests, but understandably difficult to do in sandboxed environments
@GrahamcOfBorg build python27Packages.srp python37Packages.digi-xbee python37Packages.srp python38Packages.digi-xbee python38Packages.srp |
@JeffLabonte congrats on your first PR :) |
Thank you @jonringer ! Thank you for your time, your patience and your knowledge! Hope to work again together! |
Motivation for this change
Those are packages that I use at work for some of my devices, I felt like it would be a good idea
to share with the community packages I made for myself.
Things done
Create package called digi-xbee 1.3.0 and srp 1.0.15
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)