Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearlyU: split outputs in out and otb #79638

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 9, 2020

Motivation for this change

Issue #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested fonts are working in X11 and GTK application
  • Tested compilation of all pkgs that depend on this change using
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Note: The spacing seems off in urxvt using Xft:ClearyU, someone who's accustomed to the original should double check, if possible.

ping @7c6f434c

@7c6f434c
Copy link
Member

I have not used it as the main terminal font ever, so I cannot check. On the other hands, fixing spacing during conversion sounds like a pretty involved operation, so maybe we should not block providing some OTB version on that.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 14, 2020

Ok, after having tried the original pcf I can say that the spacing has not changed.
I fixed a small issue and used install instad of cp.

@rnhmjoj rnhmjoj merged commit dc62c39 into NixOS:master Feb 14, 2020
@rnhmjoj rnhmjoj deleted the clearlyU branch April 7, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants