Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hobbes: init at latest #79699

Merged
merged 3 commits into from Mar 12, 2020
Merged

hobbes: init at latest #79699

merged 3 commits into from Mar 12, 2020

Conversation

thmzlt
Copy link
Contributor

@thmzlt thmzlt commented Feb 10, 2020 •
edited

Motivation for this change

Introducing the hobbes programming and execution environment build and maintained at Morgan Stanley.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thmzlt
Copy link
Contributor Author

thmzlt commented Feb 10, 2020

Looking into the build timeout. It passes on Travis CI.

doronbehar
doronbehar requested changes Feb 10, 2020
View reviewed changes
pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hobbes/default.nix Show resolved Hide resolved
doronbehar
doronbehar reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that all LGTM.

pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 1, 2020

What else can I do to help with this PR? Do I need to tick all the boxes on the template list?

@doronbehar
Copy link
Contributor

You can try and write at https://discourse.nixos.org/t/prs-already-reviewed/2617 . I don't have merge permissions so I've done as best as I could. Since I can see this is your first contribution, 1st of all welcome aboard :) And 2ndly, get used to it - PRs can take a longgg of time.

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 1, 2020

Thanks @doronbehar!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/106

@aanderse
Copy link
Member

aanderse commented Mar 9, 2020

@thmzlt after reading the upstream guide to building it seems like more recent gcc and llvm should work... did you try?
I believe @danieldk has a comment about python and checkInputs which hasn't been addressed yet.

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 9, 2020

@thmzlt after reading the upstream guide to building it seems like more recent gcc and llvm should work... did you try?

Building with latest GCC and LLVM fails. There are open issues on upstream for that.

I believe @danieldk has a comment about python and checkInputs which hasn't been addressed yet.

I'll fix it later today when I have a chance and let you know. Thank you all for guiding me on this PR.

@aanderse
Copy link
Member

aanderse commented Mar 9, 2020

@thmzlt awesome! Links to upstream issues always appreciated so future updates can easily check if these issues are resolved or not.

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 10, 2020

Pushed changes to set Python as a check phase input. Should be good to go.

Regarding the issues related to LLVM/GCC versions, they are:

Both issues are expected to be fixed.

@danieldk
Copy link
Contributor

Pushed changes to set Python as a check phase input. Should be good to go.

Cool, thanks!

Regarding the issues related to LLVM/GCC versions, they are:

Maybe it's worthwhile adding a short comment to the derivation above the respective dependencies with the links? Avoid that somebody has to hunt for PRs in the future to find these links ;).

aanderse
aanderse requested changes Mar 10, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there are a few unresolved comments from other reviewers.

pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 11, 2020

@aanderse, just pushed a new version of the derivation with your feedback. Let me know if there's anything else.

@thmzlt thmzlt requested a review from aanderse March 11, 2020 10:47
aanderse
aanderse requested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! Very close, a few more changes, a quick test, and I'm more than happy to merge. Thanks for your patience up to this point.

pkgs/development/tools/hobbes/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 11, 2020

@aanderse, I have fixed the version name, and separated the changes in two commits. I have also changed the maintiner from the upstream's maintainer to myself since I'm the one working on the derivation. Finally, I have added a comment pointing to the upstream issue on why doCheck is currently set to false, and removed the python37 input.

@thmzlt thmzlt requested a review from aanderse March 11, 2020 12:06
aanderse
aanderse approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thmzlt what a fantastic job you've done here. Welcome to the maintainers team, we're so glad to have you! 🎉

@aanderse
Copy link
Member

@GrahamcOfBorg build hobbes

@aanderse
Copy link
Member

Oh no! 😱 x86_64-darwin failure!

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 12, 2020

I can't test it on Darwin at the moment (I don't have a supported computer). Is it possible to mark this as Linux-only while I figure out how to build on a Mac?

@doronbehar
Copy link
Contributor

Yes. If upstream intended this to build on darwin, then we mark this as broken there. I.e use meta.broken = stdenv.isDarwin;.

If upstream intended this to work only on Linux, you can use the platforms meta attribute.

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 12, 2020

@GrahamcOfBorg build hobbes

@thmzlt
Copy link
Contributor Author

thmzlt commented Mar 12, 2020

Looks like we are good. Thank you all for the help.

@aanderse aanderse merged commit 76b292d into NixOS:master Mar 12, 2020
@thmzlt thmzlt deleted the hobbes branch March 12, 2020 11:54
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 12, 2020
@aanderse @dtzWill
Merge pull request NixOS#79699 from thmzlt/hobbes
d297e0f 
hobbes: init at latest
(cherry picked from commit 76b292d)
@bhipple bhipple mentioned this pull request Apr 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@aanderse aanderse aanderse approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thmzlt @doronbehar @nixos-discourse @aanderse @danieldk @Janik-Haag